Custom Hostname update function added #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2020
patryk
reviewed
Jan 15, 2020
| @@ -55,8 +55,19 @@ type CustomHostnameListResponse struct { | |||
| // hostname in the given zone. | |||
| // | |||
| // API reference: https://api.cloudflare.com/#custom-hostname-for-a-zone-update-custom-hostname-configuration | |||
| func (api *API) UpdateCustomHostnameSSL(zoneID string, customHostnameID string, ssl CustomHostnameSSL) (CustomHostname, error) { | |||
| return CustomHostname{}, errors.New("Not implemented") | |||
| func (api *API) UpdateCustomHostnameSSL(zoneID string, customHostnameID string, ssl CustomHostnameSSL) (*CustomHostnameResponse, error) { | |||
There was a problem hiding this comment.
Is there a reason you're changing return type?
There was a problem hiding this comment.
I just wanted to follow same style as it is in createCustomHostname, reponse from the API is similar on borh cases.
patryk
approved these changes
Jan 20, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Hostname Update function added
Description
Function to be able to modify the custom hostname SSL settings
Has your change been tested?
Test file updated and new library used to modify the custom hostnames
Types of changes
What sort of change does your code introduce/modify?
Checklist: