changes the ZoneCustomSSLGeoRestrictions to be a pointer

[trjstewart]

This change fixes issue #479 with the first proposed solution; change the ZoneCustomSSLGeoRestrictions to be a pointer within the ZoneCustomSSLOptions struct. This is a breaking change as it requires the ZoneCustomSSLGeoRestrictions to now be passed by reference.

Description

This is described in detail in the related Issue #479. Changing ZoneCustomSSLGeoRestrictions to be a pointer is the cleanest and more correct way to implement the fix, however I am mindful that this is a breaking change and may not be desirable.

Has your change been tested?

I have updated the existing tests to reflect the change and I don't believe it's necessary to add any additional test cases as this is simply enforcing the already established expected behavior of ZoneCustomSSLGeoRestrictions being omitted when empty.

Types of changes

What sort of change does your code introduce/modify?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[patryk]

Thanks for PR. I agree changing to the pointer is better solution, and we don't need to be that much vary of making breaking changes provided lib is still version 0.x, and the modifications themselves in other projects are minimal. Thanks for research!

[trjstewart]

Thanks @patryk. Any chance of getting this cut into a 0.11.8 release so we can update the dependency over on https://github.com/terraform-providers/terraform-provider-cloudflare?

[patryk]

Hey @trjstewart, sorry for late reply, didn't notice. We usually cut the release on a monthly cadence, or "when needed". It's not a fixed schedule.