Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert /zones -> /accounts routes for access resources #486

Merged

Conversation

Justin-Holmes
Copy link
Contributor

@Justin-Holmes Justin-Holmes commented Jun 25, 2020

Description

The access team has deprecated the /zones routes in favor of /accounts. The public docs should be released over the next several days that reflect the changes in this PR. I'll be referencing a corresponding PR in the Terraform provider repository once that's complete.

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! We can discuss how to manage the migration to account_id within the terraform provider when this is ready for use there.

With the documentation updates, will https://api.cloudflare.com/deprecations also get an update? I'm unsure of the policies there.

@Justin-Holmes
Copy link
Contributor Author

The deprecations page will be getting an update as well, but not exactly sure on when (definitely in the near future though). There won't be an "end of life" date since we don't have any plans of removing the /zones routes (AFAIK).

@Justin-Holmes
Copy link
Contributor Author

Do we have an ETA on when we think this will be released? I'm going to track this internally to make sure I don't let this fall through the cracks.

Thanks a lot for the help!

@jacobbednarz
Copy link
Member

It's generally a fortnightly/monthly release cycle depending on the importance of what is in it. @patryk can cut a release for this and we can start using it upstream too.

@patryk
Copy link
Contributor

patryk commented Jul 31, 2020

Thanks!

@patryk patryk merged commit 1101840 into cloudflare:master Jul 31, 2020
Justin-Holmes added a commit to Justin-Holmes/cloudflare-go that referenced this pull request Sep 17, 2020
Co-authored-by: Justin Holmes <jholmes@cloudflare.com>
Justin-Holmes added a commit to Justin-Holmes/cloudflare-go that referenced this pull request Sep 18, 2020
Co-authored-by: Justin Holmes <jholmes@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants