Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Notifications #662

Merged

Conversation

revathyrams
Copy link

Description

This PR aims to add support for Cloudflare's Notification APIs. Using these APIs notifications can be created/updated/deleted, and also notification destinations can be setup.

Has your change been tested?

Yes. All the methods have tests attached with them.

Types of changes

What sort of change does your code introduce/modify?

  • [ ✅ ] New feature (non-breaking change which adds functionality)

Checklist:

  • [ ✅ ] My code follows the code style of this project.
  • [ ✅ ] My change requires a change to the documentation.
  • [ ✅ ] I have updated the documentation accordingly.
  • [ ✅ ] I have added tests to cover my changes.
  • [ ✅ ] All new and existing tests passed.

@revathyrams revathyrams force-pushed the Revathy/add-notification-APIs branch from 110b30a to d7e5c4c Compare July 1, 2021 21:45
@jacobbednarz jacobbednarz merged commit 0bd6dc3 into cloudflare:master Jul 4, 2021
@jacobbednarz
Copy link
Member

woohoo! thanks @revathyrams 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants