Don't fetch unneeded DNS records in UpdateDNSRecord. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,17 +133,20 @@ func (api *API) DNSRecord(ctx context.Context, zoneID, recordID string) (DNSReco | |||
| // | |||
| // API reference: https://api.cloudflare.com/#dns-records-for-a-zone-update-dns-record | |||
| func (api *API) UpdateDNSRecord(ctx context.Context, zoneID, recordID string, rr DNSRecord) error { | |||
| rec, err := api.DNSRecord(ctx, zoneID, recordID) | |||
There was a problem hiding this comment.
thanks, this looks like a hangover from a80236a where we swapped from HTTP PUT => PATCH but still wanted the option for end users to only supply a single attribute.
There was a problem hiding this comment.
Got it. Is there something else I should change in this PR?
There was a problem hiding this comment.
Not at this stage. I'm in the process of reviewing and checking this as it's pretty critical.
|
i've had a play with this and i think we're 👌 to proceed with this. the client code i've found already passes in the full record so this shouldn't be an issue. thanks for you contribution! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this patch,
UpdateDNSRecordonly fetches the referred DNS record whenNameorTypeis empty. Previously, it always fetches the current record even if it is not used.Has your change been tested?
The original test
TestUpdateDNSRecordwas updated to rejectGETqueries. Two new testsTestUpdateDNSRecordWithoutNameandTestUpdateDNSRecordWithoutTypewere added for the cases where aGETquery is expected.Types of changes
What sort of change does your code introduce/modify?
Checklist: