WithPagination should ignore non-positive numbers.

[favonia]

Make WithPagination(PaginationOptions{}) a no-op.

Description

With... options should ignore zero values. This has been the case for various options, but not for WithPagination.

Has your change been tested?

Existing tests passed.

Types of changes

What sort of change does your code introduce/modify?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jacobbednarz]

thanks for finding this! if we're touching this code, let's take it that one step further and ensure we're only passing positive values and not allowing this library to request negative values