AUTH-3689: Adds support for access keys config endpoints #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
access_keys.go
Outdated
| // AccessKeysConfig returns the Access Keys Configuration for an account. | ||
| // API reference: https://api.cloudflare.com/#access-keys-configuration-get-access-keys-configuration | ||
| func (api *API) AccessKeysConfig(ctx context.Context, accountID string) (AccessKeysConfig, error) { | ||
| return api.accessKeysConfig(ctx, accountID, AccountRouteRoot) |
There was a problem hiding this comment.
we don't really need these intermediate methods; other Access resources have it where it's available at the account and zone level to reduce duplication.
| } | ||
|
|
||
| // AccessKeysConfig returns the Access Keys Configuration for an account. | ||
| // API reference: https://api.cloudflare.com/#access-keys-configuration-get-access-keys-configuration |
There was a problem hiding this comment.
Suggested change
| // API reference: https://api.cloudflare.com/#access-keys-configuration-get-access-keys-configuration | |
| // | |
| // API reference: https://api.cloudflare.com/#access-keys-configuration-get-access-keys-configuration |
access_keys.go
Outdated
Comment on lines
39
to
38
| // UpdateAccessKeysConfig updates the Access Keys Configuration for an account. | ||
| // API reference: https://api.cloudflare.com/#access-keys-configuration-update-access-keys-configuration |
There was a problem hiding this comment.
Suggested change
| // UpdateAccessKeysConfig updates the Access Keys Configuration for an account. | |
| // API reference: https://api.cloudflare.com/#access-keys-configuration-update-access-keys-configuration | |
| // UpdateAccessKeysConfig updates the Access Keys Configuration for an account. | |
| // | |
| // API reference: https://api.cloudflare.com/#access-keys-configuration-update-access-keys-configuration |
access_keys.go
Outdated
Comment on lines
51
to
47
| // RotateAccessKeys rotates the Access Keys for an account and returns the updated Access Keys Configuration | ||
| // API reference: https://api.cloudflare.com/#access-keys-configuration-rotate-access-keys |
There was a problem hiding this comment.
Suggested change
| // RotateAccessKeys rotates the Access Keys for an account and returns the updated Access Keys Configuration | |
| // API reference: https://api.cloudflare.com/#access-keys-configuration-rotate-access-keys | |
| // RotateAccessKeys rotates the Access Keys for an account and returns the updated Access Keys Configuration. | |
| // | |
| // API reference: https://api.cloudflare.com/#access-keys-configuration-rotate-access-keys |
GreenStage
force-pushed
the
egomes/AUTH-3689-support-access-keys-config
branch
from
e61967f to
ece521f
Compare
|
@jacobbednarz can you re-review please? I updated according to your comments |
|
looks great! thanking you @GreenStage 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for access key configuration per account.
Has your change been tested?
-Tested by updating the automated tests.
-Tested by using the sdk against the staging api
Types of changes
What sort of change does your code introduce/modify?
Checklist: