Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cache purge environment aware #267

Merged

Conversation

jafowler
Copy link
Contributor

This PR aims to make the zone cache functions environment aware. As of right now, the plan is to allow users to include zone versioning environments when they call their cache purge functions.

php vendor/bin/phpunit --configuration phpunit.xml
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

...............................................................  63 / 158 ( 39%)
............................................................... 126 / 158 ( 79%)
................................                                158 / 158 (100%)

Time: 4.8 seconds, Memory: 8.00MB

OK (158 tests, 983 assertions)

Copy link

@mgirouard mgirouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

remove commas to make <php7.2 happy

Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@jafowler jafowler force-pushed the make-cache-purge-environment-aware branch from 7b25cd8 to 0a78ed0 Compare December 17, 2024 22:42
@jacobbednarz jacobbednarz merged commit 2d3f198 into cloudflare:master Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants