Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break compatibility with draft 04 #351

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Break compatibility with draft 04 #351

merged 2 commits into from
Jul 13, 2023

Conversation

cjpatton
Copy link
Contributor

Partially addresses #350.

@cjpatton cjpatton mentioned this pull request Jun 20, 2023
Closed
mendess
mendess reviewed Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@mendess mendess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a kv breaking change at least, right? What else could this possibly break?

@cjpatton
Copy link
Contributor Author

This is a kv breaking change at least, right? What else could this possibly break?

This is a breaking change for draft-04 of the spec only; draft-02 is not impacted.

@cjpatton cjpatton changed the base branch from draft05 to main July 13, 2023 18:57
@cjpatton
Break compatibility with draft-ietf-ppm-dap-04
35efbf8 
We are moving to draft 05. To begin, update the references and update
the version tags.
@cjpatton cjpatton changed the title Replace draft04 references with draft05 Break compatibility with draft 04 Jul 13, 2023
@cjpatton
Copy link
Contributor Author

Fixed clippy

@cjpatton cjpatton merged commit 0785e28 into main Jul 13, 2023
4 checks passed
@cjpatton cjpatton deleted the cjpatton/350/1/bump branch July 13, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendess mendess mendess left review comments

@bhalleycf bhalleycf bhalleycf approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@captain-mota captain-mota Awaiting requested review from captain-mota

@chris-wood chris-wood Awaiting requested review from chris-wood

@will118 will118 Awaiting requested review from will118

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjpatton @mendess @bhalleycf