Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize e2e tests #371

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Reorganize e2e tests #371

merged 2 commits into from
Jul 14, 2023

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Jul 14, 2023

This organization let's us remove the allow(dead_code) directives and also
lets us remove the e2e_ prefix from the tests since the test name will get
that from the module name.

@mendess mendess self-assigned this Jul 14, 2023
@mendess mendess force-pushed the mendess/reorganize-e2e-tests branch 4 times, most recently from 5fa7d01 to 06852a6 Compare July 14, 2023 15:22
@mendess mendess force-pushed the mendess/reorganize-e2e-tests branch from 06852a6 to 822b3c3 Compare July 14, 2023 15:24
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Much nicer

@mendess mendess merged commit 8c8d0e6 into main Jul 14, 2023
4 checks passed
@mendess mendess deleted the mendess/reorganize-e2e-tests branch July 14, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants