Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bincode for DO request serialization #382

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Use bincode for DO request serialization #382

merged 1 commit into from
Aug 7, 2023

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Aug 7, 2023

Bincode reduces the size of payloads by more than 50%

@mendess mendess self-assigned this Aug 7, 2023
@mendess mendess force-pushed the mendess/improve-parsing-of-do-requests branch 2 times, most recently from 063e988 to 42d119a Compare August 7, 2023 17:43
cjpatton
cjpatton requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One change request, which is to implement Derive manually on types that have sensitive contents.

daphne_worker/src/durable/helper_state_store.rs Show resolved Hide resolved
daphne/src/vdaf/mod.rs Outdated Show resolved Hide resolved
daphne/src/vdaf/mod.rs Outdated Show resolved Hide resolved
daphne_worker/src/durable/mod.rs Outdated Show resolved Hide resolved
@mendess mendess force-pushed the mendess/improve-parsing-of-do-requests branch 2 times, most recently from 8017041 to 8c716a4 Compare August 7, 2023 18:17
cjpatton
cjpatton approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare in mind that, once deployed, there may be a period in which the Worker attempts a request to a still running DO that has the old code, causing a 500. This period of time should hopefully be short.

@mendess mendess force-pushed the mendess/improve-parsing-of-do-requests branch from 8c716a4 to bd09cb2 Compare August 7, 2023 18:31
@mendess mendess merged commit d619133 into main Aug 7, 2023
4 checks passed
@mendess mendess deleted the mendess/improve-parsing-of-do-requests branch August 7, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpatton cjpatton cjpatton approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@captain-mota captain-mota Awaiting requested review from captain-mota

@chris-wood chris-wood Awaiting requested review from chris-wood

Assignees

@mendess mendess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendess @cjpatton