draft07, taskprov: Align VdafConfig and clean up
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
mendess
as code owners
mendess
approved these changes
Nov 28, 2023
cjpatton
force-pushed
the
cjpatton/next-dap-10
branch
from
0a16b6f to
703c334
Compare
cjpatton
force-pushed
the
cjpatton/next-dap-11
branch
from
6d0c040 to
62e036d
Compare
|
Rebased. |
cjpatton
force-pushed
the
cjpatton/next-dap-10
branch
from
703c334 to
0671e26
Compare
Align serialization of `VdafConfig` with the latest draft. Along the way, remove the `VdafType` and simplify. This struct is used only for aligning the VDAF verify key derivation with `ring`'s HKDF API. It's sufficient (and simpler) to implement the necessary trait on our own `VdafVerifyKey` type.
cjpatton
force-pushed
the
cjpatton/next-dap-11
branch
from
62e036d to
b34b025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #350.
Stacked on #438.
Align serialization of
VdafConfigwith the latest draft. Along the way, remove theVdafTypeand simplify. This struct is used only for aligning the VDAF verify key derivation withring's HKDF API. It's sufficient (and simpler) to implement the necessary trait on our ownVdafVerifyKeytype.