taskprov: Improve extension payload handling #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
mendess
as code owners
cjpatton
commented
Nov 28, 2023
cjpatton
force-pushed
the
cjpatton/next-dap-13
branch
3 times, most recently
from
6d957e1 to
45fafba
Compare
mendess
reviewed
Nov 29, 2023
cjpatton
force-pushed
the
cjpatton/next-dap-12
branch
from
ef17992 to
76f6dd7
Compare
cjpatton
force-pushed
the
cjpatton/next-dap-13
branch
from
45fafba to
2bdfc8c
Compare
mendess
approved these changes
Nov 29, 2023
cjpatton
force-pushed
the
cjpatton/next-dap-12
branch
from
76f6dd7 to
26ad064
Compare
* If taskprov is disabled for the task, then handle the extension as unrecognized. * If taskprov is enabled, then assert that the extension payload is empty (in draft07). * Fence the payload consistency check to draft02. While at it, align unimplemented-extension serialization with other unimplemented fields.
cjpatton
force-pushed
the
cjpatton/next-dap-13
branch
from
2bdfc8c to
440f762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #350.
Stacked on #441.