Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require async when decrypting reports #692

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Oct 9, 2024

Decrypting reports usually happens as they are consumed, which is a CPU bound
task. Not requiring async for this has a few advantages:

  • it can be more easily offloaded to a thread outside the async runtime to
    prevent it from blocking the runtime
  • it can be more easily benchmarked and flamegraphed, as flamegraphing async
    functions is almost impossible

@mendess mendess self-assigned this Oct 9, 2024
@mendess mendess force-pushed the mendess/make-hpke-decrypter-not-async branch 2 times, most recently from e00aa85 to 9716b8f Compare October 9, 2024 15:00
@mendess mendess force-pushed the mendess/make-hpke-decrypter-not-async branch from 9716b8f to 7a53440 Compare October 9, 2024 15:17
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mendess mendess merged commit 024ea34 into main Oct 11, 2024
3 checks passed
@mendess mendess deleted the mendess/make-hpke-decrypter-not-async branch October 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants