Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize dapf #695

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Reorganize dapf #695

merged 5 commits into from
Oct 17, 2024

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Oct 15, 2024

  • Separate out human friendly parsers of DAP types to seperate module
  • Cleanup TestAction::CreateAddTaskJson
  • create dap functions module
  • Move to functions::helper the code needed to make a request to the helper
    which will allow us to possibly reuse this code in a individual dapf function

@mendess mendess requested a review from armfazh as a code owner October 15, 2024 10:12
@mendess mendess self-assigned this Oct 15, 2024
@mendess mendess force-pushed the mendess/organize-dapf branch 2 times, most recently from 4ef30f1 to fe28a27 Compare October 15, 2024 11:19
cjpatton
cjpatton approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits only. Note one of the commit titles is so long that GitHub splits it out into the commit body. I think it's a good idea to make the title fit on one line so that git log is easier to read.

crates/dapf/src/cli_parsers.rs Outdated Show resolved Hide resolved
crates/dapf/src/cli_parsers.rs Show resolved Hide resolved
crates/dapf/src/cli_parsers.rs Outdated Show resolved Hide resolved
crates/daphne-service-utils/src/test_route_types.rs Show resolved Hide resolved
crates/dapf/src/functions/mod.rs Outdated Show resolved Hide resolved
crates/dapf/src/functions/mod.rs Show resolved Hide resolved
crates/dapf/src/acceptance/mod.rs Outdated Show resolved Hide resolved
@mendess
Move to functions::helper the code needed to make a request to the he…
ea56afd 
…lper

This will allow us to possibly reuse this code in a individual dapf function
@mendess mendess requested a review from cjpatton October 17, 2024 13:46
@mendess mendess merged commit 2b5e141 into main Oct 17, 2024
3 checks passed
@mendess mendess deleted the mendess/organize-dapf branch October 17, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@fisherdarling fisherdarling Awaiting requested review from fisherdarling fisherdarling is a code owner

@cbranch cbranch Awaiting requested review from cbranch cbranch is a code owner

@lbaquerofierro lbaquerofierro Awaiting requested review from lbaquerofierro lbaquerofierro is a code owner

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy Noah-Kennedy is a code owner

@RageKnify RageKnify Awaiting requested review from RageKnify RageKnify is a code owner

@cjpatton cjpatton Awaiting requested review from cjpatton cjpatton is a code owner

Assignees

@mendess mendess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendess @cjpatton