-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for external BTF #320
Conversation
havefuncoding1
commented
Nov 14, 2023
- Introduced new command line argument '--btfpath' to support external BTF so the tool can be used on system without vmlinx. External BTFs are available here.
- Updated kernel version check for biolatency. Without it, in my environment running 5.10.178 kernel, the exporter runtime fails with 'Invalid argument'. @ntnx-aleksa just wanted to bring this to your awareness since you made initial update in commit 5511eae. Hope changes here don't break anything.
Hi @bobrik I noticed there is no reviewer automatically assigned to open PRs. Is there a way to get someone to review this? Thanks. |
Do you plan on using this? If it unlocks older kernels, you might want to add some docs into
Could you open a separate PR for this?
I get notified for everything, but I'm also short on time. I review when I get a chance. |
Thanks a lot @bobrik for reviewing this. Made all changes per your comments and will send a separate PR for kernel version update in biolatency.btf.c. |
I'm still interested in the answer to this:
|
Yes I will have to use it for my target environments. Otherwise, I wouldn't have implemented the solution. |
Please squash the commits into one. |
839bd52
to
9160dff
Compare
Done. Thanks a lot for reviewing this @bobrik |
Could you remove protections your master branch in your fork? I have a few small changes that I want to add before merging, but I can't push them:
|
I did a quick search to remove repo protection. The results all points to configure protection rules which I have none. Not sure how to best proceed :(. If you have a pointer, it will be really great. Otherwise, I added you as a collaborator so you can push changes. Can't assign you write access yet as invitation is pending. Another option is to share the changes with me, and I can push them to the PR. I am fine with whichever method you think is most convenient. Apology for lack of github experience. |
Somehow I messed it up, so I opened #323 as a replacement. |