add dname decoder #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's one complaint from the linter, LGTM otherwise. What metrics are you gathering with this? |
This decoder will convert DNS qname wire format into human readable "." notation domain name.
|
I'm mainly getting the count for DNS query names, with labels focus only on type A/AAAA/other. Because the constant stack restriction in ebpf VM, decode doesn't work there. One of the build failed with an HTTP 502 error this time, don't think the linter is unhappy though, maybe you could help me rerun it? |
|
I restarted the build and it's happy now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decoder will convert DNS qname wire format into human readable
"." notation domain name.