Support dynamic charset change on meta tags in HtmlRewriter.
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orium
changed the title
meta tags in HtmlRewriter.meta tags in HtmlRewriter.
orium
force-pushed
the
charset-meta-tag
branch
3 times, most recently
from
2dc0790 to
175043c
Compare
inikulin
requested changes
Mar 15, 2023
src/rewriter/mod.rs
Outdated
| use std::rc::Rc; | ||
| use thiserror::Error; | ||
|
|
||
| pub use self::settings::*; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct SharedEncoding { |
There was a problem hiding this comment.
Done. Does it make sense to also move AsciiCompatibleEncoding to base/encoding.rs? We would export it in a different place so it is a breaking change...
There was a problem hiding this comment.
Actually, SharedEncoding is not exported. It is only used internally. Do you still want to have it in the base module?
inikulin
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.