Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miniflare 3: Cache API doesn't work from Miniflare service binding #475

Closed
vlovich opened this issue Jan 17, 2023 · 1 comment · Fixed by #515
Closed

Miniflare 3: Cache API doesn't work from Miniflare service binding #475

vlovich opened this issue Jan 17, 2023 · 1 comment · Fixed by #515
Labels
tre Relating to Miniflare 3

Comments

@vlovich
Copy link
Contributor

vlovich commented Jan 17, 2023 •
edited
Loading

If you have a service binding that then calls into cache, this doesn't work because the request has the wrong MF-Custom-Service set for the service binding but cache uses the same header.
@mrbbot mrbbot added the tre Relating to Miniflare 3 label Jan 25, 2023
mrbbot added a commit that referenced this issue Feb 20, 2023
@mrbbot
Strip MF-Custom-Service header from request param, closes #475
58864b7 
Previously, the `MF-Custom-Service` header was including on the
`request` parameter passed to custom service functions. This usually
wasn't a problem, but if the request ever made it back to the
loopback server (e.g. via `caches.default.put(request, ...)`), it
would be forwarded back to the custom service instead of the
appropriate plugin router.
@mrbbot mrbbot linked a pull request Feb 20, 2023 that will close this issue
[Miniflare 3] Assorted fixes #515
Merged
mrbbot added a commit that referenced this issue Feb 27, 2023
@mrbbot
Strip MF-Custom-Service header from request param, closes #475
fa6f4a1 
Previously, the `MF-Custom-Service` header was including on the
`request` parameter passed to custom service functions. This usually
wasn't a problem, but if the request ever made it back to the
loopback server (e.g. via `caches.default.put(request, ...)`), it
would be forwarded back to the custom service instead of the
appropriate plugin router.
mrbbot added a commit that referenced this issue Feb 27, 2023
@mrbbot
Fix cache tests following #515's preserving URL change
2c8bcd3 
Similar to #475, we weren't deleting the `MF-Original-Header` URL
from incoming requests, leading to incorrect URLs in the loopback
server when the incoming request was passed-through as the cache key.

Tests also needed to be updated as the storage location is now based
off the actual URL passed to `dispatchFetch()`.
@mrbbot mrbbot mentioned this issue Feb 27, 2023
Merged
mrbbot added a commit that referenced this issue Feb 27, 2023
@mrbbot
Fix cache tests following #515's preserving URL change
9ceb21f 
Similar to #475, we weren't deleting the `MF-Original-URL` header
from incoming requests, leading to incorrect URLs in the loopback
server when the incoming request was passed-through as the cache key.

Tests also needed to be updated as the storage location is now based
off the actual URL passed to `dispatchFetch()`.
mrbbot added a commit that referenced this issue Feb 27, 2023
@mrbbot
Fix cache tests following #515's preserving URL change (#523)
3daafd5 
Similar to #475, we weren't deleting the `MF-Original-URL` header
from incoming requests, leading to incorrect URLs in the loopback
server when the incoming request was passed-through as the cache key.

Tests also needed to be updated as the storage location is now based
off the actual URL passed to `dispatchFetch()`.
@mrbbot
Copy link
Contributor

mrbbot commented Mar 2, 2023

Closed by #515 👍

@mrbbot mrbbot closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tre Relating to Miniflare 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Miniflare 3] Assorted fixes cloudflare/miniflare
2 participants
@vlovich @mrbbot