Actually respect port and host option
#424
Conversation
Previously, `port` was being passed through `get-port` before being used. This meant that if `Miniflare` was disposed and then immediately created again (as opposed to using `setOptions`), it couldn't use the same `port`, as `get-port` deliberately doesn't allocate recently allocated ports. Notably, Wrangler does exactly this: re-create `Miniflare` instances. Ideally, we should be using `setOptions` there, but this at least means the port stays the same between reloads. This PR also passes the `host` option to `workerd`, now that we're not putting an HTTP proxy in front of `workerd` in Miniflare.
|
Ctrl/CMD-cliking on this URL in VSCode included the `!` in the URL, opening the wrong URL in browser.
| // TODO: respect entry `host` option | ||
| this.#runtime = new this.#runtimeConstructor(entryPort, loopbackPort); | ||
| const host = this.#sharedOpts.core.host ?? "127.0.0.1"; | ||
| const port = this.#sharedOpts.core.port ?? (await getPort({ port: 8787 })); |
There was a problem hiding this comment.
This will now fail if core.port is in use, rather than falling back to 8787
There was a problem hiding this comment.
I actually think this is nicer behaviour. If the user is explicitly setting the port option, we should fail if we can't bind to that port. Previously, this option was acting more like preferredPort which I don't think is right. If users want this behaviour, they could call getPort themselves before calling new Miniflare().
Previously,
portwas being passed throughget-portbefore being used. This meant that ifMiniflarewas disposed and then immediately created again (as opposed to usingsetOptions), it couldn't use the sameport, asget-portdeliberately doesn't allocate recently allocated ports.Notably, Wrangler does exactly this: re-create
Miniflareinstances. Ideally, we should be usingsetOptionsthere, but this at least means the port stays the same between reloads.This PR also passes the
hostoption toworkerd, now that we're not putting an HTTP proxy in front ofworkerdin Miniflare.