Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these fixes is split into a separate commit for easier reviewing. 🙂
cachePersist
option was being ignored, so cached data couldn't be persisted@cloudlfare/kv-asset-handler
automatically caches files, so we need to disable the Cache API for these URIs.cache: false
option for disabling the cache. The Cache API was still available, it just didn't do anything.workers.dev
subdomains: Cache API operations are no-ops onworkers.dev
subdomains. This is a common cause of confusion, so this PR also brings over Miniflare 2'scacheWarnUsage: true
option. We can set this in Wrangler if we detect the user will be publishing to aworkers.dev
zone.