Log uncaught source-mapped errors to the console #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JacobMGEvans
approved these changes
Nov 23, 2022
penalosa
reviewed
Nov 24, 2022
penalosa
requested changes
Nov 24, 2022
| const sourceFile = maybeGetFile(workerSrcOpts, file); | ||
| if (sourceFile?.path === undefined) return null; | ||
|
|
||
| // Find the last source mapping URL if any |
There was a problem hiding this comment.
sourceMappingURL may appear in earlier comments/string-literals and we want to ignore those. This is what source-map-support and get-source (dependency of stacktracey) do.
Previously, errors _thrown_ using the `MF-Experimental-Error-Stack` header were only shown in a pretty-error page. This PR logs those errors with source-maps applied to the console too, using the `source-map-support` package. This simplifies our code, and also means we don't need to touch internal Youch methods, as the errors we pass to Youch are already source-mapped.
mrbbot
force-pushed
the
tre-log-source-mapped-errors
branch
from
53f8850 to
2341ed8
Compare
penalosa
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, errors thrown using the
MF-Experimental-Error-Stackheader were only shown in a pretty-error page. This PR logs those errors with source-maps applied to the console too, using thesource-map-supportpackage. This simplifies our code, and also means we don't need to touch internal Youch methods, as the errors we pass to Youch are already source-mapped.