Cache API tests #447
Merged
Cache API tests #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrbbot
force-pushed
the
tre-cache-tests
branch
from
74d77be to
7790ee2
Compare
| @@ -246,7 +253,8 @@ export class CacheGateway { | |||
| throw new StorageFailure(); | |||
| } | |||
|
|
|||
| await this.storage.put<CacheMetadata>(request.url, { | |||
| cacheKey ??= request.url; | |||
JacobMGEvans
approved these changes
Nov 28, 2022
penalosa
reviewed
Nov 28, 2022
penalosa
approved these changes
Nov 30, 2022
mrbbot
force-pushed
the
tre-cache-tests
branch
from
7790ee2 to
15ffc9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing for Miniflare 3's Cache API. I've written these as integration tests. Along the way, I fixed some bugs with caching streamed responses, and using
cf.cacheKey.This PR is pretty big, because it also adds lots of the required integration testing infrastructure. Hopefully, it should be easier to add tests for other features after this.