You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the abnormal closure close code 1006 was passed directly to StandardWebSocket#close(). This is forbidden, throwing an uncatchable validation error. With this change, the WebSocket is terminate()ed instead, propagating the 1006 code correctly to the other side of the connection.
Previously, the abnormal closure close code `1006` was passed
directly to `StandardWebSocket#close()`. This is forbidden, throwing
an uncatchable validation error. With this change, the WebSocket
is `terminate()`ed instead, propagating the `1006` code correctly to
the other side of the connection.
Ref #493
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I wanted to access this symbol in a test as regular close() rejects code 1006 as it's reserved (admittedly I probably shouldn't be relying on internal behaviour in the tests), but I don't want to expose this to users of the @miniflare/web-sockets package. Marking it as @internal will hide it from the bundled *.d.ts file, but API extractor requires all internal symbols be prefixed with an _.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mrbbot
changed the title
Previously, the abnormal closure close code
1006was passed directly toStandardWebSocket#close(). This is forbidden, throwing an uncatchable validation error. With this change, the WebSocket isterminate()ed instead, propagating the1006code correctly to the other side of the connection.Closes #465
Ref #493