[Miniflare 3] Support durableObjectsPersist option
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrbbot
changed the title
durableObjectsPersist optiondurableObjectsPersist option
penalosa
requested changes
Feb 23, 2023
Uses cloudflare/workerd#302 to enable Durable Object persistence. - `durableObjectsPersist: undefined | false | "memory:"` stores "in-memory" - `durableObjectsPersist: true` stores under `.mf` on the file-system - `durableObjectsPersist: "(file://)?<path>"` stores under `<path>` on the file-system Note Miniflare 2 persisted in-memory data between options reloads. In Miniflare 3, `workerd` restarts on every reload, so if we used `workerd`'s in-memory storage, we'd lose data every time options changed. To maintain Miniflare 2's behaviour, "in-memory" storage isn't actually in-memory. Instead, we write to a temporary directory and clean this up on `dispose()`/exit. 🙈 Also fixes a bug if multiple services bound to the same Durable Object class. This would result in duplicate entries in `durableObjectClassNames`. This has been changed from a `Map` of `string[]`s to a `Map` of `Set<string>`s to enforce the uniqueness constraint. Closes cloudflare/workers-sdk#2403 Closes cloudflare/workers-sdk#2458 Internal ticket: DEVX-219
mrbbot
force-pushed
the
tre-durable-objects-persist
branch
from
e8b0ae0 to
8eda364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses cloudflare/workerd#302 to enable Durable Object persistence.
durableObjectsPersist: undefined | false | "memory:"stores "in-memory"durableObjectsPersist: truestores under.mfon the file-systemdurableObjectsPersist: "(file://)?<path>"stores under<path>on the file-systemNote Miniflare 2 persisted in-memory data between options reloads. In Miniflare 3,
workerdrestarts on every reload, so if we usedworkerd's in-memory storage, we'd lose data every time options changed. To maintain Miniflare 2's behaviour, "in-memory" storage isn't actually in-memory. Instead, we write to a temporary directory and clean this up ondispose()/exit. 🙈Also fixes a bug if multiple services bound to the same Durable Object class. This would result in duplicate entries in
durableObjectClassNames. This has been changed from aMapofstring[]s to aMapofSet<string>s to enforce the uniqueness constraint.Closes cloudflare/workers-sdk#2403
Closes cloudflare/workers-sdk#2458
Internal ticket: DEVX-219