Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for requests to miniflare #550

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Add logging for requests to miniflare #550

merged 1 commit into from
Apr 3, 2023

Conversation

jspspike
Copy link

@jspspike jspspike commented Mar 30, 2023 •
edited
Loading

Addresses this issue

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3de1b29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jspspike jspspike force-pushed the jspspike/response-print branch 3 times, most recently from 029e08e to f61877d Compare March 30, 2023 15:49
@jspspike jspspike requested a review from mrbbot March 30, 2023 16:16
@jspspike jspspike force-pushed the jspspike/response-print branch from f61877d to b7098e7 Compare March 30, 2023 16:34
mrbbot
mrbbot reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 Thanks for doing this! 😃 I've added some comments...

packages/tre/src/plugins/core/index.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/index.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/log.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/log.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/log.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/log.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/log.ts Outdated Show resolved Hide resolved
packages/tre/src/plugins/core/index.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/response-print branch from b7098e7 to 9d95066 Compare March 31, 2023 16:52
@jspspike jspspike requested a review from mrbbot March 31, 2023 16:52
@jspspike jspspike force-pushed the jspspike/response-print branch 2 times, most recently from 7f05784 to 7345982 Compare March 31, 2023 18:59
mrbbot
mrbbot reviewed Apr 3, 2023
View reviewed changes
packages/tre/src/shared/log.ts Outdated Show resolved Hide resolved
packages/tre/src/shared/log.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/response-print branch from 7345982 to d6d7f10 Compare April 3, 2023 18:47
@jspspike jspspike requested a review from mrbbot April 3, 2023 18:48
mrbbot
mrbbot approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approve with one tiny nit 🙂

packages/tre/src/plugins/core/index.ts Outdated Show resolved Hide resolved
@jspspike jspspike force-pushed the jspspike/response-print branch 2 times, most recently from 5fae7e3 to b567e3a Compare April 3, 2023 22:37
@jspspike jspspike force-pushed the jspspike/response-print branch from b567e3a to 3de1b29 Compare April 3, 2023 22:54
@jspspike jspspike merged commit dae7719 into tre Apr 3, 2023
@jspspike jspspike deleted the jspspike/response-print branch April 3, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspspike @mrbbot