[Miniflare 3] Use UTC timezone when building current compatibility date #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrbbot
changed the title
|
The CI failure is the same as #551, and should be fixed once that's merged. |
RamIdeas
approved these changes
Apr 17, 2023
When a user specifies a compatibility date, Miniflare compares it against the current date to make sure it's not in the future. Previously, we used the system timezone when getting the current date. Wrangler's default compatibility date is the current date in the _UTC_ timezone. This meant Miniflare occasionally thought Wrangler's compatibility date was in the future. This change updates Miniflare to always use UTC when getting the current date. Closes cloudflare/workers-sdk#2881
mrbbot
force-pushed
the
tre-utc-compat-date
branch
from
4a40d00 to
3ec85b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user specifies a compatibility date, Miniflare compares it against the current date to make sure it's not in the future. Previously, we used the system timezone when getting the current date. Wrangler's default compatibility date is the current date in the UTC timezone. This meant Miniflare occasionally thought Wrangler's compatibility date was in the future. This change updates Miniflare to always use UTC when getting the current date.
Closes cloudflare/workers-sdk#2881