Allow setOptions() to set runtime port

[GregBrimble]

No idea if this is even vaguely right, but here's a first stab at fixing #608.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 03663fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mrbbot]

I think this should work, but I'd prefer we use the same Runtime instance across reloads. Could we add an entryPort option to updateConfig()...

miniflare/packages/miniflare/src/runtime/index.ts

Line 107 in cfddac3

options?: Abortable

...then set this here based on runtimeEntryURL.port if !initial?

miniflare/packages/miniflare/src/index.ts

Lines 788 to 790 in cfddac3

	const maybePort = await this.#runtime.updateConfig(configBuffer, {
	signal: this.#disposeController.signal,
	});

We'd need to extract args construction out of the Runtime constructor() and into a separate method too.

[GregBrimble]

Tidied this up while I was here. But lemme know if you want me to pull that change out :)

[mrbbot]

One tiny thing, then looks good to me! ✅

[mrbbot]

CI seems a little borked, but I don't think it's related to this PR. Merging this now, and will investigate today 👍