Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module __STATIC_CONTENT_MANIFEST #622

Closed
wants to merge 1 commit into from

Conversation

armfazh
Copy link

@armfazh armfazh commented Jul 1, 2023

Workers Sites sets the module __STATIC_CONTENT_MANIFEST to store paths to static assets.
Documentation: https://miniflare.dev/storage/sites#internal-details

Related Changes

workerd - needs to detect the module. See cloudflare/workerd#828
miniflare - needs to detect the module. See this PR.
workers-sdk - needs to detect the module. See cloudflare/workers-sdk#3084
workers-rs - requires changes to workerd, miniflare and workers-sdk. See cloudflare/workers-rs#308

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2023

⚠️ No Changeset found

Latest commit: 3168ecb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa
Copy link
Contributor

penalosa commented Jul 5, 2023

Going forward, we’ll be overhauling the Sites/Assets system as part of Pages/Workers convergence, and will inherit the benefits of the Pages assets system.

In the meantime, Pages is the best choice for deploying sites with static assets.

@penalosa penalosa closed this Jul 5, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Jul 17, 2023

Re-opening this PR as a fix for #630. Miniflare 3 provides support for Workers Sites via sitePath, but this option is broken if using automatic module collection. The comment above still holds, but given Miniflare is already providing support, we should make sure it works.

@mrbbot mrbbot reopened this Jul 17, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Jul 17, 2023

Closing this in favour of #631 which adds a few more fixes required to get sites to work. 👍

@mrbbot mrbbot closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants