[Miniflare 3] Split certificates from NODE_EXTRA_CA_CERTS
#637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `NODE_EXTRA_CA_CERTS` contains multiple certificates, they need to be split before being passed to `workerd`. This change fixes that, and adds a test for `NODE_EXTRA_CA_CERTS` handling in general.
|
RamIdeas
approved these changes
Jul 24, 2023
kentonv
reviewed
Jul 24, 2023
| trustedCertificates.push(extra); | ||
| // Split bundle into individual certificates and add each individually: | ||
| // https://github.com/cloudflare/miniflare/pull/587/files#r1271579671 | ||
| const pemBegin = "-----BEGIN"; |
There was a problem hiding this comment.
Does PEM actually specify exactly 5 - and no whitespace? I've always assumed the format was looser than that but I guess I don't know.
There was a problem hiding this comment.
Looks like it: https://datatracker.ietf.org/doc/html/rfc7468#section-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
NODE_EXTRA_CA_CERTScontains multiple certificates, they need to be split before being passed toworkerd. This change fixes that, and adds a test forNODE_EXTRA_CA_CERTShandling in general as promised.