Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use relative imports in miniflare core #664

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

ajwootto
Copy link
Contributor

  • switch @miniflare/core to use relative imports to its own files rather than self-referencing its package name
  • should fix usage in pnpm-style package installation environments

fixes #663

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 00c17ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot merged commit d8f7218 into cloudflare:master Aug 25, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Aug 25, 2023

Hey! 👋 I've just released version 2.14.1 which includes this change. Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@miniflare/core package seems to require itself, breaking pnpm-style installation
2 participants