[Miniflare 3] Return copy of entry URL from Miniflare#ready
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where mutating the URL returned from `Miniflare#ready` may be desirable, e.g. changing the protocol to `ws:` and using the `ws` module to establish a WebSocket connection. Previously, doing this would break Miniflare's `dispatchFetch`, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.
|
penalosa
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 There are cases where mutating the URL returned from
Miniflare#readymay be desirable, e.g. changing the protocol tows:and using thewsmodule to establish a WebSocket connection. Previously, doing this would break Miniflare'sdispatchFetch, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.