Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miniflare 3] Allow custom workerd binary via MINIFLARE_WORKERD_PATH variable #682

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Sep 8, 2023

Hey! 👋 This change allows a custom workerd binary to be used when running Miniflare, by setting the MINIFLARE_WORKERD_PATH environment variable. This is an environment variable, not a config option, so it can be customised when running Miniflare through Wrangler too. This will very useful for debugging issues.

@mrbbot mrbbot requested a review from a team September 8, 2023 21:56
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

⚠️ No Changeset found

Latest commit: 8ef4700

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot marked this pull request as ready for review September 8, 2023 22:00
Copy link

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests? 😄

This change allows a custom `workerd` binary to be used when running
Miniflare, by setting the `MINIFLARE_WORKERD_PATH` environment
variable. This is an environment variable, not a config option, so
it can be customised when running Miniflare through Wrangler too.
@mrbbot mrbbot merged commit 4453e4e into tre Sep 11, 2023
8 checks passed
@mrbbot mrbbot deleted the bcoll/tre-custom-workerd branch September 11, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants