decouple MF-Original-URL header from disabling the pretty-error page #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now uses MF-Disable-Pretty-Error header explicitly
|
RamIdeas
commented
Sep 20, 2023
mrbbot
approved these changes
Sep 28, 2023
instead of ""
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Oct 5, 2023
Use `MF-Disable-Pretty-Error` instead of `MF-Original-URL` for disabling the pretty-error page in the `additional-modules` fixture test. This was changed in cloudflare/miniflare#689.
2 tasks
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Oct 5, 2023
Use `MF-Disable-Pretty-Error` instead of `MF-Original-URL` for disabling the pretty-error page in the `additional-modules` fixture test. This was changed in cloudflare/miniflare#689.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.cfdata.org/browse/DEVX-945 for context
TL;DR this PR decouples the
MF-Original-URLheader from disabling the pretty-error page and instead uses an explicitMF-Disable-Pretty-Errorheader to disable it.This allows
MF-Original-URLto be set without disabling the pretty-error page.