[Miniflare 3] Add additional traps to magic proxy stubs #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds `getOwnPropertyDescriptor`, `ownKeys` and `getPrototypeOf` traps to magic proxy stubs. The first two allow proxy stubs to be `JSON.stringify`ed. The last ensures proxies aren't detected as plain objects.
|
dario-piotrowicz
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
from my non-existent knowledge of the codebase the changes look good to me 🙂
I did manually test this and seems to be working as expected, thanks a bunch @mrbbot 😄 🚀
RamIdeas
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 This change adds
getOwnPropertyDescriptor,ownKeysandgetPrototypeOftraps to magic proxy stubs. The first two allow proxy stubs to beJSON.stringifyed. The last ensures proxies aren't detected as plain objects.