[Miniflare 3] Avoid using temporary directory if possible #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miniflare 2 persisted data in-memory between `setOptions()` calls when `*Persist` options were disabled. Whilst `workerd` has in-memory storage for Durable Objects, this is reset when `workerd` is restarted (i.e. when `setOptions()` is called). To retain Miniflare 2 behaviour in Miniflare 3, we actually persist to a temporary directory when `*Persist` options are disabled. There are cases where we don't need the temporary directory though: if we have no storage bindings configured, `cache` is `false`, and `unsafeEphemeralDurableObjects` is `true`. This change ensures we don't write to the temporary directory in these cases.
|
RamIdeas
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miniflare 2 persisted data in-memory between
setOptions()calls when*Persistoptions were disabled. Whilstworkerdhas in-memory storage for Durable Objects, this is reset whenworkerdis restarted (i.e. whensetOptions()is called). To retain Miniflare 2 behaviour in Miniflare 3, we actually persist to a temporary directory when*Persistoptions are disabled. There are cases where we don't need the temporary directory though: if we have no storage bindings configured,cacheisfalse, andunsafeEphemeralDurableObjectsistrue. This change ensures we don't write to the temporary directory in these cases.Ref: cloudflare/workers-sdk#4167