expose preventEviction as unsafePreventEviction for Durable Objects #726
Conversation
for durable object bindings
|
packages/miniflare/src/index.ts
Outdated
| if (existingInfo?.unsafeUniqueKey !== unsafeUniqueKey) { | ||
| throw new MiniflareCoreError( | ||
| "ERR_DIFFERENT_UNIQUE_KEYS", | ||
| `Multiple unsafe unique keys defined for Durable Object "${className}" in "${serviceName}": ${JSON.stringify( | ||
| unsafeUniqueKey | ||
| )} and ${JSON.stringify(existingUnsafeUniqueKey)}` | ||
| )} and ${JSON.stringify(existingInfo?.unsafeUniqueKey)}` | ||
| ); | ||
| } |
There was a problem hiding this comment.
Could you add a similar check for unsafePreventEviction? Since a Durable Object can have multiple bindings to it, and this configuration is defined at the binding level, but set in workerd with each Durable Object, we need to make sure unsafePreventEviction is configured the same on all bindings to the same Durable Object.
There was a problem hiding this comment.
Added. Do you want a test for this behaviour? Can't see one for existingUnsafeUniqueKey
There was a problem hiding this comment.
Not too worried about it, but if you're offering... 😃
across all bindings to each durable object
|
Going to merge this now. I'm about to start the migration to |
No description provided.