Specify production branch #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our team uses Cloudflare Pages, and we need to get an alias URL for our develop branch. However, our project has set the default branch to develop, instead of the main production branch, to prevent accidental PRs to the production branch.
The current implementation seems to recognize the production branch based on whether it is the default branch or not. As a result, we are unable to get an alias URL for our develop branch.
Solution
To address this issue, I have implemented a feature that allows users to explicitly specify the production branch. This gives us more control and flexibility in managing our deployment workflow, even when the default branch is not the production branch.
To generate the sanitized branch name for the alias URL, I used the code from this GitHub repository. This code is based on this discussion in the Cloudflare community forums.
The branch name sanitization process ensures that the generated alias URL conforms to the required format and does not include any invalid characters or patterns.
As this is my first Pull Request, I would appreciate any guidance or suggestions to improve the quality of my contribution.