Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrangler pages publish => wrangler pages deploy #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wrangler pages publish => wrangler pages deploy #134

wants to merge 1 commit into from
+1 −1

Conversation

irvinebroque
Copy link

@irvinebroque irvinebroque requested a review from a team as a code owner July 8, 2024 15:03
GregBrimble
GregBrimble requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change since we supported Wrangler before this rename. If they haven't pinned the Action but have pinned their Wrangler version, this'll fail. Just blocking this for now while we consider the rollout strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregBrimble GregBrimble GregBrimble requested changes

@nprogers nprogers nprogers approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irvinebroque @GregBrimble @nprogers