Implementation of arbitrary batched tokens #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a new token type, but a new token serialisations. Based off of ietf-wg-privacypass/ietf-draft-privacypass-batched-tokens#13
Generate new tests vectors for arbitrary batched tokens
Have both the public and private key when generating batch tokens In addition, ignore fields which are null in the output json
Test is generated and verified
Arbitrary batched tokens need dictionaries.
|
this relates to ietf-wg-privacypass/ietf-draft-privacypass-batched-tokens#21 |
armfazh
reviewed
Nov 25, 2024
There was a problem hiding this comment.
- how to handle multiple types within the "arbitrary" batched array. Go does not work well with the generic approach proposed in the draft
For simplicity, you need to start using Go interfaces. Go generics may help, but later, once you have common interfaces for the types/API you want to generalize.
- how to correctly expose internals of other tokens type to arbitrary batched tokens, for testing purposes. Specifically, the test vector require blinds to be exposed, which is not possible at the moment.
here I see two options:
Like in JS/TS implementation, we mock the random number generator, so you can inject the blinding values without exposing internals.
In go, I usually write:
- a private method/function (those with underscore names)
createRequest(blind []byte)
- a public function.
CreateRequest() { createRequest(rand.Reader) } ```
Thus, tests are written to check only internal functions. In each case, you have to refactor the current code.
| return nil, fmt.Errorf("invalid Tokens encoding") | ||
| } | ||
|
|
||
| respTokens := make([][]byte, 0) |
There was a problem hiding this comment.
Suggested change
| respTokens := make([][]byte, 0) | |
| var respTokens [][]byte |
| casted, ok := tokenRequest.(*typeF91A.BatchedPrivateTokenRequest) | ||
| if !ok || casted.Type() != typeF91A.BatchedPrivateTokenType { | ||
| return nil, fmt.Errorf("invalid token request type") | ||
| } |
There was a problem hiding this comment.
add a default case to catch unsupported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of draft 3 of arbitrary batched tokens as defined in ietf-draft-privacypass-batched-tokens.
The implementation is short, test is much longer. The goal is not to be exhaustive, the draft suggest only tokens type 1 and token type 2 would be supported first.
For review, I am looking for: