Fix h2 request_summary #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error is interesting, maybe unrelated to this PR but I encountered it also in my own work: This warning seems likely to be followed with Upstream broken pipe. I don't know if this is as expected, or likely a bug. If needed, I can file an issue about this. |
|
CI error looks like a flaky test. That warning is expected, it means an error occurred and since we already wrote response headers we cannot send them again with the error status. |
andrewhavck
added
the
Accepted
drcaramelsyrup
pushed a commit
that referenced
this pull request
Aug 16, 2024
drcaramelsyrup
pushed a commit
that referenced
this pull request
Aug 16, 2024
|
synced |
escoffier
pushed a commit
to escoffier/pingora
that referenced
this pull request
Sep 6, 2024
--- also add port number --- also print query with path for h2 just as h1 Includes-commit: 2df4e29 Includes-commit: 53e1810 Includes-commit: 8102a09 Replicated-from: cloudflare#345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, HTTP/2
request_summaryuse HOST header for printing host, which is empty. While thepathis also different from HTTP/1.x.Before:
HTTP/1.x:
HTTP/2:
After this change:
HTTP/2: