allow proxy to set stream level downstream read timeout #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhavck
reviewed
Jan 10, 2025
| /// This is a noop for h2. | ||
| pub fn set_read_timeout(&mut self, timeout: Duration) { | ||
| match self { | ||
| Self::H1(s) => s.set_write_timeout(timeout), |
There was a problem hiding this comment.
We'll want to invoke set_read_timeout here rather than set_write_timeout.
There was a problem hiding this comment.
sorry about that; have fixed
|
Linked to #506 |
andrewhavck
added
the
Accepted
|
87ae8ce cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these timeouts were already implemented and had unit tests, but were missing the API on the Session to allow configurability from ProxyHttp callbacks.