Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging consistency for github releases #393

Closed
visheyra opened this issue Sep 28, 2022 · 1 comment · Fixed by #412
Closed

packaging consistency for github releases #393

visheyra opened this issue Sep 28, 2022 · 1 comment · Fixed by #412

Comments

@visheyra
Copy link

visheyra commented Sep 28, 2022

Hi there,

While automating the download and execution of pint across various devices (mainly apple m1 arm64 and x86_64 linux) I noticed a difference in packaging.

When one download the darwin arm64 release the tarball contains the arm64 arch both in the name of the archive and within the archive

link:https://github.com/cloudflare/pint/releases/download/v0.30.2/pint-0.30.2-darwin-arm64.tar.gz

❯ ls pint-0.30.2-darwin-arm64
LICENSE			README.md		pint-darwin-arm64

However, for the linux release, the arch in the binary name has been changed

link: https://github.com/cloudflare/pint/releases/download/v0.30.2/pint-0.30.2-linux-x86_64.tar.gz
content:

❯ ls pint-0.30.2-linux-x86_64
LICENSE			README.md		pint-linux-amd64

While it is not a huge problem I see 2 reasons why this should be fixed:

  • when working with uname the expected architecture output on linux 64 bits is x86_64 not amd64
  • it's a pain to write cross platform scripts due to that

I would be happy to help you tackle / PR this issue LMK

@prymitive
Copy link
Collaborator

#412 should fix this for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants