Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test coverage #1165

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add more test coverage #1165

merged 1 commit into from
Oct 25, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.66.1-57-g8cd062f
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Oct 24, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.84m ± 2%   40.68m ± 4%       ~ (p=0.631 n=10)
CheckRules-4     8.511 ± 2%    8.514 ± 2%       ~ (p=0.631 n=10)
geomean         589.6m        588.5m       -0.18%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.089 n=10)
CheckRules-4    984.5Mi ± 0%   983.7Mi ± 0%       ~ (p=0.063 n=10)
geomean         164.3Mi        164.2Mi       -0.04%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.897 n=10)
CheckRules-4    14.28M ± 0%   14.28M ± 0%  -0.03% (p=0.011 n=10)
geomean         1.372M        1.372M       -0.02%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (e233a20) to head (8cd062f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         103      103           
  Lines       12166    12168    +2     
=======================================
+ Hits        11534    11536    +2     
  Misses        482      482           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 95af10f into main Oct 25, 2024
20 checks passed
@prymitive prymitive deleted the tests branch October 25, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants