Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JSON reporter #1169

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add a JSON reporter #1169

merged 1 commit into from
Oct 25, 2024

Conversation

prymitive
Copy link
Collaborator

Fixes #606.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.66.1-59-g45d90da
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.63m ± 1%   40.30m ± 1%  +1.70% (p=0.003 n=10)
CheckRules-4     8.490 ± 2%    8.531 ± 2%       ~ (p=0.315 n=10)
geomean         580.1m        586.4m       +1.09%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.579 n=10)
CheckRules-4    987.6Mi ± 0%   986.8Mi ± 0%       ~ (p=0.218 n=10)
geomean         164.5Mi        164.5Mi       -0.04%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.071 n=10)
CheckRules-4    14.30M ± 0%   14.29M ± 0%       ~ (p=0.247 n=10)
geomean         1.373M        1.373M       -0.01%

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.79%. Comparing base (95af10f) to head (45d90da).

Files with missing lines Patch % Lines
internal/reporter/console.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   94.80%   94.79%   -0.01%     
==========================================
  Files         103      104       +1     
  Lines       12168    12207      +39     
==========================================
+ Hits        11536    11572      +36     
- Misses        482      484       +2     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit d009d5d into main Oct 25, 2024
20 checks passed
@prymitive prymitive deleted the json branch October 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output lint result as a machine friendly format
2 participants