Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve template label checks #78

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Improve template label checks #78

merged 1 commit into from
Nov 25, 2021

Conversation

prymitive
Copy link
Collaborator

Add more test cases and improve logic

Add more test cases and improve logic
@codecov-commenter
Copy link

Codecov Report

Merging #78 (b92428f) into main (8b79532) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   75.18%   75.28%   +0.09%     
==========================================
  Files          59       59              
  Lines        3377     3390      +13     
==========================================
+ Hits         2539     2552      +13     
  Misses        730      730              
  Partials      108      108              
Impacted Files Coverage Δ
internal/checks/alerts_template.go 91.84% <100.00%> (ø)
internal/parser/utils/aggregation.go 63.41% <100.00%> (+16.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b79532...b92428f. Read the comment docs.

@prymitive prymitive merged commit cca7a93 into main Nov 25, 2021
@prymitive prymitive deleted the improve-labels branch November 25, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants