Update clear key logic #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbaquerofierro
force-pushed
the
lina/update-key-cleanup
branch
from
7c1b4e0
to
2a867bd
Compare
thibmeu
reviewed
Oct 14, 2024
lbaquerofierro
force-pushed
the
lina/update-key-cleanup
branch
11 times, most recently
from
09cccbb
to
bb052f2
Compare
thibmeu
reviewed
Oct 14, 2024
kcxlee
reviewed
Oct 14, 2024
kcxlee
reviewed
Oct 14, 2024
lbaquerofierro
force-pushed
the
lina/update-key-cleanup
branch
from
bb052f2
to
db48816
Compare
…SPAN (48H), except last uploaded key
lbaquerofierro
force-pushed
the
lina/update-key-cleanup
branch
from
db48816
to
c50918c
Compare
Key rotation and clearance tests have a lot of copy paste, making them hard to review and update. This commit moves them to `each` format.
thibmeu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update clear key logic, delete keys after prevRotationDate + KEY_LIFE…SPAN (48H), except last uploaded key. This creates a 48h grace period for old keys after a key has being rotated