-
Notifications
You must be signed in to change notification settings - Fork 46
build Python 3.11.14 #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build Python 3.11.14 #183
Conversation
…build dependencies
🦋 Changeset detectedLatest commit: c31dd16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
🐳 Docker Image PublishedFROM cloudflare/sandbox:0.0.0-pr-183-4d9a1d2Version: You can use this Docker image with the preview package from this PR. |
c02f3ae to
9a42a65
Compare
Claude Code ReviewStatus: Issues found - recommend addressing before merge Critical Issues1. Potential cache mount permission issues (line 82) The cache mount at Recommendation: Use 2. Incomplete cleanup (line 100)
Recommendation: Either rely on cache mount cleanup or explicitly clean up within the RUN layer. Minor Issues3. Using Recommendation: Remove 4. Image size regression PR description mentions "image size is 1GB now" - this is a significant increase. Previous approach likely used system packages (~200-300MB lighter). While pre-built Python may offer performance benefits, the size trade-off should be justified. Recommendation: Document WHY this approach was chosen (performance? version pinning? reliability?) in the PR description or commit message. Positive Changes
Testing RecommendationsBefore merge, verify:
|
The file command is required by FileService for MIME type detection. Without it, all file read operations fail with 500 errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Verified this fixed my problem |
ghostwriternr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just removed the python source cleanup, to avoid unexpected issues with production python codebases that we can't yet anticipate. Can prune later if size becomes a bigger concern.
Downloading 3.11.14 directly from the source, image size is 1GB now