Update dependencies and fix tests #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two problems in the tests: First, ping6 may not be available everywhere. In this case, fall back to the ping command. Second, the endianness of the pcap test file is not necessarily big endian.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project does not build with the current gVisor release. Therefore, a7241b2 updates the dependencies, in particular gVisor.
Also, tests are run using
make testinstead ofmake tests:slirpnetstack/Makefile
Line 41 in 41e49c3
881a555 adapts the tests. gVisor now writes pcaps in LE byte order:
https://github.com/google/gvisor/blob/a0f4020ea5f3806040d0e076cc62b968fc20005d/pkg/tcpip/link/sniffer/sniffer.go#L98