adds validation to only allow valid DNS record types

cloudflare · Mar 4, 2020 · a820a89 · a820a89
1 parent a58cec0
commit a820a89
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/cloudflare/resource_cloudflare_record.go b/cloudflare/resource_cloudflare_record.go
@@ -9,6 +9,7 @@ import (
 
 	cloudflare "github.com/cloudflare/cloudflare-go"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 )
 
 func resourceCloudflareRecord() *schema.Resource {
@@ -45,9 +46,10 @@ func resourceCloudflareRecord() *schema.Resource {
 			},
 
 			"type": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.StringInSlice([]string{"A", "AAAA", "CNAME", "TXT", "SRV", "LOC", "MX", "NS", "SPF", "CERT", "DNSKEY", "DS", "NAPTR", "SMIMEA", "SSHFP", "TLSA", "URI"}, false),
 			},
 
 			"value": {